Files
HKSingleParty/99_references/cf-identity-wallet-main/.github/PULL_REQUEST_TEMPLATE.md
2025-05-28 09:55:51 +08:00

1.4 KiB

Description

Please include a summary of the changes and a brief description about this PR

Checklist before requesting a review

  • This PR has a valid ticket number or issue: [link]

Testing & Validation

  • This PR has been tested/validated in IOS, Android and browser.
  • The code has been tested locally with test coverage match expectations.
  • Added new Unit/Component testing (if relevant).

Security

  • No secrets are being committed (i.e. credentials, PII)
  • This PR does not have any significant security implications

Code Review

  • There is no unused functionality or blocks of commented out code (otherwise, please explain below)
  • In addition to this PR, all relevant documentation (e.g. Confluence) and architecture diagrams (e.g. Miro) were updated

Design Review

  • If this PR contains changes to the UI, it has gone through a design review with UX Designer or Product owner.
  • In case PR contains changes to the UI, add some screenshots to notice the differences

IOS

Before
After

Android

Before
After

Browser

Before
After